Fixing shebang statements for edge cases#1105
Merged
stonedDiscord merged 2 commits intoAttorneyOnline:masterfrom Jul 28, 2025
Merged
Fixing shebang statements for edge cases#1105stonedDiscord merged 2 commits intoAttorneyOnline:masterfrom
stonedDiscord merged 2 commits intoAttorneyOnline:masterfrom
Conversation
There are systems (though rare) that don't have bash, but instead only have sh, or zsh, etc, which would otherwise be able to use our shell scripts, there's no reason to not allow the environment to select its shell.
This applies to both the dynamic and appimage installations
stonedDiscord
approved these changes
Jul 28, 2025
Contributor
|
The script does require bash to find the script's directory though, so that would also need to be changed to actually make it compatible with other shells. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are systems (though rare) that don't have bash, but instead only have sh, or zsh, etc, which would otherwise be able to use our shell scripts, there's no reason to not allow the environment to select its shell.